Unzip flat directory #8208
Merged
Unzip flat directory #8208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSE4
reviewed
Dec 14, 2020
memsharded
reviewed
Dec 14, 2020
|
what do you think on returning the flat directory, so it could be chained like: |
|
But this feature removes the directory... why do you want to return it? |
lasote
commented
Dec 15, 2020
| @@ -72,17 +71,6 @@ | |||
| """ | |||
|
|
|||
|
|
|||
| def zipdir(path, zipfilename): | |||
memsharded
reviewed
Dec 15, 2020
conans/client/tools/files.py
Outdated
| @@ -55,7 +55,8 @@ def human_size(size_bytes): | |||
| return "%s%s" % (formatted_size, suffix) | |||
|
|
|||
|
|
|||
| def unzip(filename, destination=".", keep_permissions=False, pattern=None, output=None): | |||
| def unzip(filename, destination=".", keep_permissions=False, pattern=None, output=None, | |||
| flat_folder=False): | |||
There was a problem hiding this comment.
flat_folder name could be improved?, I would read it as getting rid of all levels of subfolders, not just dropping the first level one
There was a problem hiding this comment.
sure, suggestions? crop_first_folder, flat_first....?
There was a problem hiding this comment.
Co-authored-by: James <james@conan.io>
memsharded
reviewed
Dec 15, 2020
conans/client/tools/files.py
Outdated
| @@ -55,7 +55,8 @@ def human_size(size_bytes): | |||
| return "%s%s" % (formatted_size, suffix) | |||
|
|
|||
|
|
|||
| def unzip(filename, destination=".", keep_permissions=False, pattern=None, output=None): | |||
| def unzip(filename, destination=".", keep_permissions=False, pattern=None, output=None, | |||
| flat_folder=False): | |||
There was a problem hiding this comment.
memsharded
approved these changes
Dec 15, 2020
Co-authored-by: James <james@conan.io>
SSE4
reviewed
Dec 16, 2020
SSE4
approved these changes
Dec 16, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: The
tools.get,tools.unzipandtools.untargznow accept a new argumentstrip_root=Trueto unzip moving all the files to the parent folder when all of them belongs to a single folder.Docs: conan-io/docs#1967
Closes #6479
When a zip file structure is the following:
If you use the
flat_folder=Trueit will extract: