Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test agains Clang for ClangCL toolset #8218

Merged
merged 2 commits into from Dec 21, 2020
Merged

Test agains Clang for ClangCL toolset #8218

merged 2 commits into from Dec 21, 2020

Conversation

Psy-Kai
Copy link
Contributor

@Psy-Kai Psy-Kai commented Dec 17, 2020

Changelog: Fix: Let CMake generator generate code for checking against "ClangCL" msvc toolset.
Docs: Omit

Without that fix the generated conanbuildinfo.cmake would check for compiler and just fail because cmake detected clang but the code would compare with "MSVC".

Fixes #5896
May also fix the #1839 for Visual Studio 2019

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@memsharded memsharded added this to the 1.33 milestone Dec 20, 2020
conans/client/generators/cmake_common.py Outdated Show resolved Hide resolved
@memsharded
Copy link
Member

Approved, but please take into account these hints for Conan direction:

  • The cmake generator will be replaced by the CMakeToolchain and CMakeDeps (forked from cmake_find_package_multi generator), that are still experimental, but planned to replace it in Conan 2.0
  • There is a mechanism to skip the compiler check, just as a tip to unblock: define the CMake variable CONAN_DISABLE_CHECK_COMPILER

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using clang-cl with libraries compiled with Visual Studio doesn't work
2 participants