Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5535 venv powershell infinite prompt #8228

Merged

Conversation

mjvankampen
Copy link
Contributor

@mjvankampen mjvankampen commented Dec 18, 2020

Changelog: Bugfix: Make prompt names unique when using multiple virtualenv scripts in Powershell.
Docs: Omit

Fixes #5535

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far.

One thing I would try to implement (not for this PR, just for us, later), is when this becomes a customizable generator, to be able to give it a custom name, not just the "virtualenv", "virtualrunenv" name.

@memsharded memsharded added this to the 1.33 milestone Dec 18, 2020
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@memsharded memsharded merged commit 22c83e7 into conan-io:develop Dec 22, 2020
@mjvankampen mjvankampen deleted the fix/venv-powershell-infinite-prompt branch January 1, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtualenv activate scripts cause infinite loop in Powershell when multiple are activated
3 participants