Specify build modules by the generator in cpp_info #8232
Conversation
There was a problem hiding this comment.
As commented by @jgsogo if we would like to keep the previous "global" build_modules so we don't break to users (even if experimental), I would vote for adding the functionality for new generators only, that do not need an aggregated dict of build_modules, because every file will include its own ones.
|
Added the possibility of reading build_modules as a list and adding the specific |
conans/test/functional/generators/cmake_find_package_multi_test.py
Outdated
Show resolved
Hide resolved
| @@ -557,37 +557,49 @@ def setUp(self): | |||
| cpp_info = CppInfo(ref.name, "dummy_root_folder1") | |||
| cpp_info.filter_empty = False # For testing purposes only | |||
| cpp_info.name = ref.name | |||
| cpp_info.build_modules = ["my-module.cmake"] | |||
There was a problem hiding this comment.
Will the assignment fail? I see the existing implementation keeps append() and extend(), but not sure about the build_modules = ["..."] one. Would this be breaking?
There was a problem hiding this comment.
No, you have a specific test for that case here https://github.com/conan-io/conan/pull/8232/files#diff-3779db7bbc92daafae06a9e61c096a7970fe9fb3e9345183947061183d7c5612R249
Co-authored-by: James <james@conan.io>
| @@ -390,7 +390,7 @@ def package_info(self): | |||
| """) | |||
| # This is a module that defines some functionality | |||
| find_module = textwrap.dedent(""" | |||
| function(conan_message MESSAGE_OUTPUT) | |||
| function(custom_message MESSAGE_OUTPUT) | |||
There was a problem hiding this comment.
to avoid using conan_message() defined by the generator
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
|
added to the changelog! |
Changelog: Feature: Specify build modules by the generator in
cpp_info. Added backwards compatibility for*.cmakebuild modules added at global scope, but not for other file extensions.Docs: conan-io/docs#1986
developbranch, documenting this one.