Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in MakeGenerator #8301

merged 4 commits into from Jan 8, 2021


Copy link

@memsharded memsharded commented Jan 7, 2021

Changelog: Bugfix: Fix bug in definition of ROOT variables in MakeGenerator.
Docs: Omit

MakeGenerator was using rootpath instead of root.

I also did some refactors to simplify it a bit, reducing the number of methods, making them private,

@memsharded memsharded added this to the 1.33 milestone Jan 7, 2021
Copy link

solvingj commented Jan 8, 2021

Yes, this looks like a bug, good find.

@memsharded memsharded merged commit 4038919 into conan-io:develop Jan 8, 2021
2 checks passed
@memsharded memsharded deleted the refactor/makegenerator branch January 8, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants