Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix in MakeGenerator #8301

Merged
merged 4 commits into from Jan 8, 2021
Merged

Bugfix in MakeGenerator #8301

merged 4 commits into from Jan 8, 2021

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jan 7, 2021 •
edited by czoido

Changelog: Bugfix: Fix bug in definition of ROOT variables in MakeGenerator.
Docs: Omit

MakeGenerator was using rootpath instead of root.

I also did some refactors to simplify it a bit, reducing the number of methods, making them private,

@memsharded memsharded added this to the 1.33 milestone Jan 7, 2021
@solvingj
Copy link
Contributor

solvingj commented Jan 8, 2021

Yes, this looks like a bug, good find.

@memsharded memsharded merged commit 4038919 into conan-io:develop Jan 8, 2021
@memsharded memsharded deleted the refactor/makegenerator branch January 8, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solvingj solvingj solvingj approved these changes

Assignees

@solvingj solvingj

Labels
None yet
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@memsharded @solvingj