Fix SCM by making user and password url-encoded #8355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Jan 19, 2021
jgsogo
reviewed
Jan 19, 2021
| return "{scheme}://{user}:{password}@{url}".format(scheme=scheme, | ||
| user=quote_plus(the_user), | ||
| password=quote_plus(the_password), | ||
| url=url) |
There was a problem hiding this comment.
other schemes like file or git should execute quote_plus too?
There was a problem hiding this comment.
file format is excluded in this return https://github.com/conan-io/conan/pull/8355/files#diff-dae658b6639940b7fd00c86a6ce57086f89c33ed5ae3a40a9a91f8ac49c12cd4R77, not sure for git
There was a problem hiding this comment.
Apparently it is not supported in the URL https://stackoverflow.com/questions/31801271/what-are-the-supported-git-url-formats and git protocol has no authentication support https://stackoverflow.com/a/33846897/9585455
jgsogo
approved these changes
Jan 19, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: BugFix: Fix SCM user and password by making them url-encoded
Docs: omit
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.