Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolchain support for qbs.targetPlatform property #8372

Merged
merged 1 commit into from Jan 27, 2021
Merged

Add toolchain support for qbs.targetPlatform property #8372

merged 1 commit into from Jan 27, 2021

Conversation

Psy-Kai
Copy link
Contributor

@Psy-Kai Psy-Kai commented Jan 21, 2021

The Qbs property qbs.targetPlatform defines the os of the build target
(or "none" for bare-metal devices). When implementing the Qbs toolchain I wrongly assumed
that it would be outputted by qbs-setup-toolchains. With this PR the QbsToolchain class will
set the qbs.targetPlatform property based on the value in settings.os.

Changelog: Fix: Set qbs.targetPlatform with qbs toolchain.
Docs: Omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

The Qbs property `qbs.targetPlatform` defines the os of the build target
(or "none" for bare-metal devices). I wrongly assumed that it would be
outputted by `qbs-setup-toolchains`.
@Psy-Kai
Copy link
Contributor Author

Psy-Kai commented Jan 21, 2021

@rweickelt Would you like to review this too?

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @rweickelt wants to do another review?

@memsharded memsharded added this to the 1.34 milestone Jan 27, 2021
Copy link
Contributor

@rweickelt rweickelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for fixing.

@memsharded memsharded merged commit fe8ec51 into conan-io:develop Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants