Tests/modernize #8445
Merged
Tests/modernize #8445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
reviewed
Feb 8, 2021
| @@ -358,7 +358,7 @@ class CMakeDeps(object): | |||
| components_target_build_type_tpl = Template(textwrap.dedent("""\ | |||
| ########## MACROS ########################################################################### | |||
| ############################################################################################# | |||
| include(${{CMAKE_CURRENT_LIST_DIR}}/cmakedeps_macros.cmake) | |||
| include(${CMAKE_CURRENT_LIST_DIR}/cmakedeps_macros.cmake) | |||
There was a problem hiding this comment.
there is no test for this, right? components and CMakeDeps is barely tested
There was a problem hiding this comment.
Not really, I think it was partially discovered by some changes I did in the test, but not a explicit one. The thing is that we will move (copying first) all existing tests in cmake_find_package_multi to CMakeDeps, so all this will be more than covered, so it is probably not deserving its own new test for this.
czoido
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fixing a
CMakeDepsbug with components, not finding the conan_macros.cmake file.Docs: Omit
Fix: #8434
Also a refactor of test that highly reduce time, reusing same built package.