[WIP] Locks + cache for multiple revisions #8510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Feb 25, 2021
|
|
||
| class RWLock(object): | ||
| def __init__(self, resource: str, interprocess_lock: str): | ||
| self.w_lock = threading.Lock() |
There was a problem hiding this comment.
I am checking possible multi-threading race conditions, and given the structure of the program, typical operation (parallel uploads, parallel downloads), etc., we can guarantee by the business logic that multithreaded operations within the same process will not collide or produce race conditions with itself. Thus, lets simplify this, leaving only the interprocess lock, the simplicity will pay off
|
The work here is being continued in #8796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: (Feature | Fix | Bugfix): Describe here your pull request
Docs: https://github.com/conan-io/docs/pull/XXXX
Requirements
Keep in mind:
#5513