New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More layouts: Generators folder, CMake Toolchain, Editable packages and more #8554
Merged
lasote
merged 135 commits into
conan-io:develop
from
lasote:feature/base_layout_editables
May 13, 2021
Merged
More layouts: Generators folder, CMake Toolchain, Editable packages and more #8554
lasote
merged 135 commits into
conan-io:develop
from
lasote:feature/base_layout_editables
May 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
commented
May 12, 2021
lasote
commented
May 12, 2021
memsharded
reviewed
May 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have pushed a couple of minor things:
- CMake() was broken for some local flows, because not finding the
conanbuild.json
file (sorry, no tests, I was checking manually) - Redundant
layout()
call, it was already run insiderun_configure_method()
Please check ffaa4cb
…an into feature/base_layout_editables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Introduced the
layout()
method to the recipe to be able to declare the folder structure both for the local development methods (conan source, conan build...) and in the cache. Also, associated to the folders, cppinfo objects to be used in editable packages and file pattern descriptions to enable "auto packaging".Docs: conan-io/docs#2092
cppinfo
objects in the layout entries.clion
layout as an example (not convinced about interface/UX)