fix linker flags in cmake (find_package based) generators #8740
Conversation
conan/tools/cmake/cmakedeps.py
Outdated
| self.sharedlinkflags_list = join_flags(";", ["-{}".format(f) | ||
| for f in cpp_info.sharedlinkflags]) | ||
| self.exelinkflags_list = join_flags(";", ["-{}".format(f) for f in cpp_info.exelinkflags]) |
There was a problem hiding this comment.
Could this break flags that already start with a - or --, for non-MSVC linkers?
There was a problem hiding this comment.
Yes, good catch, I will verify that too.
There was a problem hiding this comment.
Keeping flags that already start with "-" in 4ebe404
| files = gen.content | ||
| d = files["mypkgTarget-release.cmake"] | ||
| assert "$<$<STREQUAL:$<TARGET_PROPERTY:TYPE>,EXECUTABLE>:-/OPT:NOICF>" in d | ||
| assert "$<$<STREQUAL:$<TARGET_PROPERTY:TYPE>,MODULE_LIBRARY>:-/NODEFAULTLIB;-/OTHERFLAG>" in d |
There was a problem hiding this comment.
so, is it really expected to pass -/OPT with both dash and slash?
There was a problem hiding this comment.
Apparently it worked, but you are right, better double check, I'll check it.
There was a problem hiding this comment.
yeah, that syntax looks a bit weird to me
There was a problem hiding this comment.
Ok, it was working, it didn't raise an error, but just a warning. Dropped the extra /, please check.
| files = gen.content | ||
| d = files["mypkgTarget-release.cmake"] | ||
| assert "$<$<STREQUAL:$<TARGET_PROPERTY:TYPE>,EXECUTABLE>:-/OPT:NOICF>" in d | ||
| assert "$<$<STREQUAL:$<TARGET_PROPERTY:TYPE>,MODULE_LIBRARY>:-/NODEFAULTLIB;-/OTHERFLAG>" in d |
There was a problem hiding this comment.
yeah, that syntax looks a bit weird to me
Changelog: Bugfix: Fix linker flags in cmake (find_package based) generators.
Docs: Omit
Fix: #8703
#tags: slow