fix new environment files with spaces in path #8847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czoido
approved these changes
Apr 22, 2021
memsharded
added a commit
to memsharded/conan
that referenced
this pull request
Apr 22, 2021
czoido
added a commit
that referenced
this pull request
Apr 26, 2021
* removing gcc, visual, and msbuild old generators * removing more deprecated stuff * fixing more tests * fix export manifests test * removing more legacy * fixing tests * fix test (#8840) * Feature/cmake vs toolsets (#8815) * wip * wip * working * remove dead unittest * CMake() needs CMakeToolchain * fix tests * minor refactor get_generator_platform * Return 'deprecated' attribute in 'conan inspect' command (#8832) * Return 'deprecated' attribute in 'conan inspect' command * fix tests * Exclude a package when building all from sources (#8483) * Build all package when --build= is listed If Conan install uses --build= it means all packages must be built. If another package is listed too, it doesn't matter. e.g conan install foo/0.1@ --build= --build=bar, where bar is dependency. As --build= listed, all packages will be built from sources Signed-off-by: Uilian Ries <uilianries@gmail.com> * Argument value None is a valid entry When passing --build= or --build they should be the same, but actually they are considered different. --build= means "", --build means None However it's not intuitive if you are building a package: conan install <ref> --build OR conan install <ref> --build= Signed-off-by: Uilian Ries <uilianries@gmail.com> * Validate build parameter Signed-off-by: Uilian Ries <uilianries@gmail.com> * Revert last 3 commits Signed-off-by: Uilian Ries <uilianries@gmail.com> * Validate graph build mode Signed-off-by: Uilian Ries <uilianries@gmail.com> * Add test for ignore build package Signed-off-by: Uilian Ries <uilianries@gmail.com> * Accept skipped build package Signed-off-by: Uilian Ries <uilianries@gmail.com> * Fix empty argument validation Signed-off-by: Uilian Ries <uilianries@gmail.com> * Validate build message Signed-off-by: Uilian Ries <uilianries@gmail.com> * transform namespace.build in a list Signed-off-by: Uilian Ries <uilianries@gmail.com> * Improve build argument filter Signed-off-by: Uilian Ries <uilianries@gmail.com> * Update --build help description Signed-off-by: Uilian Ries <uilianries@gmail.com> * #8442 Replace --build=! by --build-exclude Signed-off-by: Uilian Ries <uilianries@gmail.com> * fix broken arg * same behavior as --build --build=pattern * more test * #8442 Add --build=! command help Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: James <james@conan.io> * fix develop * Check Artifactory service context for conan_build_info --v2 (#8826) * check service context * add unittests * fix import * use json file! Co-authored-by: Javier G. Sogo <jgsogo@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> * fix new environment files with spaces in path (#8847) * fixed win tests Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> Co-authored-by: Javier G. Sogo <jgsogo@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Allow spaces in the path for new environment files and
conancvvars.batVisual toolchain file.Docs: omit