Bugfix: Overridden requirement not found in lockfile

[harendt]

Changelog: Bugfix: Fix that overridden requirements "cannot be found in lockfile".
Docs: omit

Fixes: #8870

In order to lock all requires of a recipe, the existing method GraphLock::lock_node() searches the requires field of a graph node for the corresponding references. But requirements with the property override=True are not included in the graph node's requires field, which leads to the error: Require '<package name>' cannot be found in lockfile. To fix this issue, the GraphLock::lock_node() method now searches transitive requires fields of a node if a requirement has the property override=True. A corresponding integration test has been added. The new integration test is failing without the fix, but passing with the fix.

• Refer to the issue that supports this Pull Request.
• If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
• I've read the Contributing guide.
• I've followed the PEP8 style guides for Python code.
• N/A (I've opened another PR in the Conan docs repo to the develop branch, documenting this one.)

^{Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.}

[CLAassistant]

All committers have signed the CLA.

[memsharded]

Hi @harendt

Sorry this has taken a while to process. I am assigning it to next release, so we allocate some time to review it.
Thanks for your contribution!

[memsharded]

Hi @harendt

I have proposed an alternative solution to this fix in #9215. The principle is that overrides do already exist as real requires elsewhere, that will be correctly extracted from the lockfile, so they can be ignored, no need to lock an override.

Please have a look. I have also added a way more simple test, probably it wasn't necessary a full CI test to fix this issue.

I wanted to do a PR to your fork, but it is a bit outdated from develop branch, and I didn't want to push changes directly. I would like to keep your contribution and your test, if you want to extract my fix and my test from this PR to yours, I'd be happy.

[harendt]

Sure, I can do that. What is your preferred way to "extract" your changes? Should I just merge your branch? Or should I cherry-pick your changes? In the latter case I would also have to rebase my branch onto the develop branch from conan-io or merge develop into my branch.

[memsharded]

Sure, I can do that. What is your preferred way to "extract" your changes? Should I just merge your branch? Or should I cherry-pick your changes? In the latter case I would also have to rebase my branch onto the develop branch from conan-io or merge develop into my branch.

As you wish, at the end, the PR is squashed and merged, so whatever is easier for you.

[memsharded]

Perfect, thanks for reporting and contributing this fix! Will be in next 1.39