Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakeToolchain: more blocks before try_compile #9009

Merged
merged 3 commits into from May 27, 2021
Merged

CMakeToolchain: more blocks before try_compile #9009

merged 3 commits into from May 27, 2021

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented May 26, 2021 •
edited

Changelog: Feature: simplified CMakeToolchain with only 1 category of blocks, made try-compile template code as another block, and reordered blocks so relevant flags for try-compile are taken into account.
Docs: conan-io/docs#2105

#tags: slow

@memsharded memsharded requested a review from lasote May 27, 2021 08:37
@memsharded memsharded marked this pull request as ready for review May 27, 2021 12:39
lasote
lasote approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solve conflict

@memsharded memsharded added this to the 1.37 milestone May 27, 2021
@memsharded memsharded merged commit d4f0c23 into conan-io:develop May 27, 2021
@memsharded memsharded deleted the feature/cmaketoolchain_blocks branch May 27, 2021 15:18
@memsharded memsharded mentioned this pull request May 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote approved these changes

Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@memsharded @lasote