CMakeDeps improvements #9015
Merged
CMakeDeps improvements #9015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…block_transitive_of_br
lasote
commented
May 28, 2021
| @@ -83,7 +97,7 @@ def get_component_alias(req, comp_name): | |||
| if comp_name not in req.new_cpp_info.components: | |||
| # foo::foo might be referencing the root cppinfo | |||
| if req.ref.name == comp_name: | |||
| return comp_name | |||
| return get_target_namespace(req) | |||
lasote
commented
May 28, 2021
| @@ -47,6 +47,7 @@ def template(self): | |||
|
|
|||
| # Only the first installed configuration is included to avoid the collission | |||
| foreach(_BUILD_MODULE {{ '${' + pkg_name + '_BUILD_MODULES_PATHS' + config_suffix + '}' }} ) | |||
| conan_message(STATUS "Conan: Including build module from '${_BUILD_MODULE}'") | |||
memsharded
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: CMakeDeps generator: The transitive requirements for a build_require are not included in the
xxx-config.cmakefiles generated.Docs: omit