Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/default skip rpaths #9024

Merged
merged 4 commits into from May 30, 2021

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented May 30, 2021

Changelog: Feature: Remove CMAKE_SKIP_RPATHS by default to True in CMakeToolchain, it is not necessary by default, users can opt-in, and new test validates shared libs will work with VirtualEnv generator conanrunenv.
Docs: conan-io/docs#2105

#tags: slow

Close #9007

@memsharded memsharded marked this pull request as ready for review May 30, 2021 17:17
@memsharded memsharded added this to the 1.37 milestone May 30, 2021
@memsharded memsharded merged commit 3fb74f5 into conan-io:develop May 30, 2021
@memsharded memsharded deleted the feature/default_skip_rpaths branch May 30, 2021 18:07
@memsharded memsharded requested a review from lasote May 30, 2021 18:07
@memsharded
Copy link
Member Author

@lasote, I have merged this to prepare 1.37 release for tomorrow, but please review anyway, just in case.

Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Change default CMakeToolchain to not remove Rpaths
2 participants