Skip when no arch is present #9045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improved test to fail if no target is generated for the build context and activating the build context explicitly * Clean msg
memsharded
reviewed
Jun 2, 2021
conan/tools/cmake/toolchain.py
Outdated
| @@ -344,6 +344,8 @@ def _apple_sdk_name(self): | |||
| def context(self): | |||
| os_ = self._conanfile.settings.get_safe("os") | |||
| host_architecture = self._get_architecture() | |||
| if host_architecture is None: | |||
There was a problem hiding this comment.
Shouldn't at least the CMAKE_SYSTEM_NAME, CMAKE_SYSTEM_VERSION for iOS, tvOS, watchOS be defined? Is it possible to have those target systems without arch?
There was a problem hiding this comment.
Yes, it is possible. It allowed to simplify the code, please check again.
memsharded
approved these changes
Jun 2, 2021
czoido
reviewed
Jun 2, 2021
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: The
CMakeToolchaingenerator now manages correctly a recipe withoutarchdeclared in an Apple system.Docs: omit