New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add support for custom server path via env or cli #9099
[feature] Add support for custom server path via env or cli #9099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I think I would prefer to have the server folder stored under the |
Hi @czoido |
Actually, this is something that will change in Conan 2.0, and the client side will be able to define directly the cache folder, without the extra |
Thanks for contributing this. If possible, it would be nice to do a PR to the docs repo to update the docs with this new feature. I think adding a couple of lines will be good enough. Then, update the |
@memsharded, thank you for accepting my PR! To update the docs I need to create a new issue on the docs repo and then submit a PR, correct? |
No need for the issue, this issue or PR is good enough for it, go directly for the PR. |
Changelog: Feature: Added support for using server config from a custom location, setting
CONAN_SERVER_HOME
env variable or using-d
or--server_dir
flag when launching the server withconan_server
command.Docs: conan-io/docs#2125
When launching from the command line the new CLI flag will be prioritized over the environment variable, this is because we want to let the user test the server with custom dirs even if an env var has been set.
I've also added some tests to test the new feature (even though currently the tests are pretty basic).
Close #9098.
Please let me know if there are any improvements to be made :)