Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix use of CMAKE_GENERATOR_TOOLSET for Ninja and use vcvars_ver #9187

Merged
merged 1 commit into from Jul 6, 2021
Merged

fix use of CMAKE_GENERATOR_TOOLSET for Ninja and use vcvars_ver #9187

merged 1 commit into from Jul 6, 2021

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jun 30, 2021 •
edited

Changelog: Bugfix: Do not define CMAKE_GENERATOR_TOOLSET in CMakeToolchain for Ninja generator, and define it in vcvars_ver instead.
Docs: Omit

Fix: #9178

@memsharded memsharded added this to the 1.39 milestone Jun 30, 2021
@memsharded memsharded mentioned this pull request Jun 30, 2021
Closed
@memsharded memsharded marked this pull request as ready for review June 30, 2021 11:56
@czoido czoido merged commit c3a2805 into conan-io:develop Jul 6, 2021
@memsharded memsharded deleted the fix/ninja_vcvars_ver_required branch July 6, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czoido czoido czoido approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
1.39
Development

Successfully merging this pull request may close these issues.

[bug] compiler = 'msvc' does not work with Ninja generator
2 participants
@memsharded @czoido