New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip cmake.test and meson.test using [conf] profile #9218
Skip cmake.test and meson.test using [conf] profile #9218
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is interesting, but probably we should further standardize the "run-test" concepts. There is demand for something more built-in and more generic, also to create conditional requirements, etc. So maybe the cmake:skip_test
and meson:skip_test
are not the best, and we should define something general, in the line of tools.build:skip_tests
. Or maybe the default should be to skip tests and tests are only enabled on demand? tools.build:tests
?
Lets see what others think.
I like it. More generic and can be re-used for other helpers. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this.
My main question is what is the right default for the future:
- Recipes, including if we want ConanCenter can add building and running tests support.
- By default tests do not build and run (good default for ConanCenter). It is possible to
[conf]
sometihng liketools.build:tests=True
, and tests will build and run - By default tests build and run (bad default for ConanCenter, probably the
tools.build:skip_tests=True
should be enforced by CI, and hooks).
Wdyt @lasote?
Not only CMake offers
test
, but Meson also has the same method.The original issue uses
skip_tests
(plural), but I thinktest
is better, because is same method name.Changelog: Feature: Skip build helper test and using [conf].
Docs: conan-io/docs#2154
close #8454
/cc @chausner
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.