Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] CONAN_TOOLCHAIN_ARGS_FILE as configuration file #9225

Conversation

franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Jul 7, 2021

Changelog: Fix: Saving all the toolchain args information into conanbuild.conf instead of json file.
Docs: conan-io/docs#2156

  • Saving all the toolchain args information into conanbuild.conf.
  • Using a default configuration section called toolchain.
  • Using ConfigParser as internal mechanism to manage the load and saving of the toolchain-file content.

Closes #9130

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@franramirez688 franramirez688 changed the title [fix] CONAN_TOOLCHAIN_ARGS_FILE is not very practical being a json file [fix] CONAN_TOOLCHAIN_ARGS_FILE as configuration file Jul 7, 2021
@franramirez688 franramirez688 marked this pull request as ready for review July 7, 2021 14:36
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, please check comments.

conan/tools/files/files.py Outdated Show resolved Hide resolved
conan/tools/files/files.py Outdated Show resolved Hide resolved
@franramirez688 franramirez688 force-pushed the fix/conan_toolchain_args_file_format_#9130 branch from 408caef to 09d1fe1 Compare July 9, 2021 07:16
@franramirez688 franramirez688 force-pushed the fix/conan_toolchain_args_file_format_#9130 branch from 9e1b5f5 to 3eff52c Compare July 9, 2021 15:55
@memsharded memsharded added this to the 1.39 milestone Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] CONAN_TOOLCHAIN_ARGS_FILE is not very practical being a json file
3 participants