Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCVars generator #9230

Merged
merged 7 commits into from Jul 9, 2021
Merged

VCVars generator #9230

merged 7 commits into from Jul 9, 2021

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Jul 7, 2021 •
edited

Changelog: Feature: New VCVars generator that generates a conanvcvars.bat that activates the Visual Studio Developer Command Prompt.
Docs: conan-io/docs#2153

Close #9213

@lasote lasote changed the title Missing more tests VCVars generator Jul 7, 2021
@lasote lasote added this to the 1.39 milestone Jul 7, 2021
@lasote lasote marked this pull request as ready for review July 8, 2021 10:02
@lasote lasote requested a review from memsharded July 8, 2021 10:02
memsharded
memsharded reviewed Jul 8, 2021
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Just a minor detail about the UI, wdyt about it?

conan/tools/microsoft/visual.py Outdated Show resolved Hide resolved
@lasote lasote mentioned this pull request Jul 9, 2021
Merged
@memsharded memsharded merged commit c218ea2 into conan-io:develop Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.39
Development

Successfully merging this pull request may close these issues.

[feature] Add a generator like class wrapping write_conanvcvars
2 participants
@lasote @memsharded