Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other types of remote archives #9530

Merged
merged 2 commits into from Sep 9, 2021

Conversation

el-g-1
Copy link
Contributor

@el-g-1 el-g-1 commented Sep 5, 2021

Changelog: Feature: Support remote archives other than zip in conan config install.
Docs: Omit
Fixes: #9382

When downloading the file, it used to be renamed to 'config.zip', which forced the file to be treated as a zip archive, disregarding its original name and extension. This change preserves the original name and extension, so the unzip call recognizes the type of the file (the unzip function already supports tar.gz and other types).

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2021

CLA assistant check
All committers have signed the CLA.

@memsharded memsharded added this to the 1.41 milestone Sep 5, 2021
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, thanks for your contribution.
Conan 1.40 has already been branch, so this will be targeted for 1.41.

@memsharded memsharded merged commit c426910 into conan-io:develop Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] can't install config from a remote .tar.gz
3 participants