Better error than 'ERROR: True' when conflicts #9633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
commented
Sep 20, 2021
| @@ -288,7 +288,8 @@ def _expand_require(self, require, node, graph, check_updates, update, remotes, | |||
| # Maybe it was an ALIAS, so we can check conflict again | |||
| conflict = self._conflicting_references(previous, require.ref, node.ref) | |||
| if conflict: | |||
| raise ConanException(conflict) | |||
| raise ConanException("Conflicting references: {} => {}".format(previous, | |||
There was a problem hiding this comment.
node.ref is None so no Exception was raised inside self._conflicting_references (this is a bit weird design). Producing a raise ConanException(True)
|
Please, tag the issues/PRs if you are working on them. |
Yes, sorry, my bad, I processed the PR first, forgot to assign the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fixed bug whereby when a conflict of requirements happens, in some special situations, just a message
ERROR: Truewas printed in the terminal, making it hard to guess what was going on.Docs: omit
Closes #9633