MSBuildDeps handle build_requires executables #9686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
approved these changes
Sep 29, 2021
conan/tools/microsoft/msbuilddeps.py
Outdated
| for dep in build_req: | ||
| dep_name = dep.ref.name | ||
| dep_name = dep_name.replace(".", "_") + "_build" | ||
| cpp_info = DepCppInfo(dep.cpp_info) # To account for automatic component aggregation |
There was a problem hiding this comment.
We could start using the new_cpp_info here and calling aggregate_components for that, the same for the host/test
There was a problem hiding this comment.
Agree, lets try it.
However, we should probably refactor that, so we can pick a name for new_cpp_info that will survive in the transition to 2.0
lasote
approved these changes
Sep 29, 2021
slietzau
pushed a commit
to slietzau/conan-center-index
that referenced
this pull request
Dec 14, 2021
This prevents a where the MSBuildDeps generator would generate invalid entries in the property sheet. Since conan-io/conan#9686 the property sheet uses variable references and assumes the include path is relative to the package dir.
4 tasks
conan-center-bot
pushed a commit
to conan-io/conan-center-index
that referenced
this pull request
Dec 18, 2021
* [hdf5/all] Use a relative include path This prevents a where the MSBuildDeps generator would generate invalid entries in the property sheet. Since conan-io/conan#9686 the property sheet uses variable references and assumes the include path is relative to the package dir. * Update recipes/hdf5/all/conanfile.py Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
miklelappo
pushed a commit
to miklelappo/conan-center-index
that referenced
this pull request
Feb 9, 2022
* [hdf5/all] Use a relative include path This prevents a where the MSBuildDeps generator would generate invalid entries in the property sheet. Since conan-io/conan#9686 the property sheet uses variable references and assumes the include path is relative to the package dir. * Update recipes/hdf5/all/conanfile.py Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature:
MSBuildDepsgenerator learned how to handlebuild_requiresto use executables from them.Docs: conan-io/docs#2248
Close #9545