Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check old cacert.pem before deleting when updating Conan #9734

Merged
merged 2 commits into from Oct 5, 2021

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Oct 5, 2021

Changelog: Fix: Check current cacert.pem file when updating Conan and only migrate if the user has not modified the file. If the local file is modified then create a new cacert file but don't overwrite current.
Docs: omit

Closes: #9731

@czoido czoido added this to the 1.40.4 milestone Oct 5, 2021
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are broken in 2.7 because of unicode conversion and comparison apparently. But otherwise looks good.

@czoido czoido merged commit 0f66845 into conan-io:release/1.40 Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants