New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the instructions created by the markdown generator #9758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you render some examples of packages with more/less dependencies to see how they look like? I'll clone this branch and run examples, too.
OTH, we surely need @lasote here, I'm not familiarized enough with these generators so I'm not sure if this is the best way to use them.
I reviewed the template with him a few weeks ago, but I'm adding him as a reviewer so we can get his input |
# Conflicts: # conan/tools/cmake/cmakedeps/templates/__init__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the image after the changes, there are already missing changes (in the screenshot). It is much easier to review a rendered example.
# Conflicts: # conan/tools/cmake/cmakedeps/templates/__init__.py
Co-authored-by: Luis Martinez <lasote@gmail.com>
Co-authored-by: Luis Martinez <lasote@gmail.com>
…into feature/new_md_readme
Looking good! 👍 How does this look if rendered inside the ConanCenter webpage? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
btw, in the image I can see two times the information for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok here.
Changelog: Feature: Update content created by the markdown generator.
Docs: conan-io/docs#2380
Closes #9746
(The following screenshot is incomplete, the list of headers is missing. Chrome didn't want me to export the full thing. You get the idea, though).