Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove misleading message about ConanCenter in shared_library_package_id() #2000

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Remove misleading message about ConanCenter in shared_library_package_id() #2000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a13f414
Remove misleading message about ConanCenter in shared_library_package…
danimtb Jan 20, 2021
2adbead
Merge branch 'master' into fix/fix_shared_library_package_id
danimtb Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions reference/conanfile/methods.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,6 @@ When a shared library links with a static library, the binary code of the later
That means that any change in the static library basically requires a new binary re-build of the shared one to integrate those changes.
Note that this doesn't happen in the static-static and shared-shared library dependencies.


Use this ``shared_library_package_id()`` helper in the ``package_id()`` method:

.. code-block:: python
Expand All @@ -999,12 +998,6 @@ option in command line or profiles, but can also be defined in recipes like:
if self.options.shared:
self.options["*"].shared = True

Using both ``shared_library_package_id()`` and this ``configure()`` method is necessary for
`Conan-center packages <https://github.com/conan-io/conan-center-index>`_ that have dependencies
to compiled libraries and have the ``shared`` option.



self.info.vs_toolset_compatible() / self.info.vs_toolset_incompatible()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down