Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example for conanrun #2519

Merged
merged 8 commits into from May 3, 2022
Merged

Example for conanrun #2519

merged 8 commits into from May 3, 2022

Conversation

franramirez688
Copy link
Contributor

Docs for #2465

@franramirez688 franramirez688 added this to the 1.48 milestone May 3, 2022
memsharded
memsharded reviewed May 3, 2022
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this extracted from some running test? Maybe it is worth copy & pasting from a test to avoid possible minor issues?

reference/conanfile/tools/env/virtualrunenv.rst Outdated Show resolved Hide resolved
reference/conanfile/tools/env/virtualrunenv.rst Outdated Show resolved Hide resolved
@franramirez688 franramirez688 linked an issue May 3, 2022 that may be closed by this pull request
how to set and use the PYTHONPATH #2465
Closed
1 task
@czoido
Copy link
Contributor

czoido commented May 3, 2022

Do we need the entire source code? Maybe just use the relevant parts?
Also, shouldn't we document this in the conanfile.py section? About the env argument in the run method and that it's defaulted to conanbuild ?

@franramirez688
Copy link
Contributor Author

Do we need the entire source code? Maybe just use the relevant parts?

Perhaps, it's clearer to see a full-working example. I guess it's fair enough to put the relevant parts but a few lines more are worth it...

Also, shouldn't we document this in the conanfile.py section? About the env argument in the run method and that it's defaulted to conanbuild ?

I already added some info there. Have a look at this PR: https://github.com/conan-io/docs/pull/2516/files If you think it's not enough I can add something more.

@franramirez688 franramirez688 requested a review from czoido May 3, 2022 15:12
@czoido czoido closed this May 3, 2022
@czoido czoido reopened this May 3, 2022
@czoido czoido closed this May 3, 2022
@czoido czoido reopened this May 3, 2022
@czoido czoido merged commit f886850 into conan-io:develop May 3, 2022
czoido added a commit that referenced this pull request May 3, 2022
@czoido @jlundy2
@franramirez688 @lucabonifacio @lasote @memsharded
Release/1.48.0 (#2520)
0ea7ec6 
* Remove reference to master banch (#2497)

It no longer exists in conan-io/consan repository

* Added conf information about new apple flags (#2506)

* Fix typo error for os_version in cmake.rst (#2515)

Fix: #2513

* Renamed all the base_source_folder -> export_sources_folder (#2514)

* Renamed all the base_source_folder -> export_sources_folder

* Update package_layout.rst

* Docs for 11112 and 11117 and 11103 (#2512)

* Docs for 11112 and 11117

* Update reference/conanfile/tools/cmake/cmaketoolchain.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

* Simplified Build Preset name

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

* [CMakeDeps] Added cmake_set_interface_link_directories property info (#2510)

* Added cmake_set_interface_link_directories property info

* Update cmakedeps.rst

* Update reference/conanfile/tools/cmake/cmakedeps.rst

Co-authored-by: Luis Martinez <lasote@gmail.com>

* Update cmakedeps.rst

* Update cmakedeps.rst

Co-authored-by: Luis Martinez <lasote@gmail.com>

* Docs for new autotools templates (#2511)

* add templates

* change argument

* [MSBuildToolchain][conf] Adding extra flags configurations to `MSBuildToolchain` (#2507)

* Added conf information

* Update microsoft.rst

* Update reference/conanfile/tools/microsoft.rst

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* Added env info to self.run() command (#2516)

* powershell env docs (#2517)

* powershell env docs

* added warning about env and PATH limits

* fixed CI

* some notes about relocatable libs (#2518)

* Docs: Add PKG_CONFIG_PATH to AutotoolsToolchain (#2509)

* add docs for PKG_CONFIG_PATH in toolchain

* Update reference/conanfile/tools/gnu/autotoolstoolchain.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Co-authored-by: Luis Martinez <lasote@gmail.com>
Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

* conan 1.48.0

* Example for conanrun (#2519)

* Added example for conanrun launcher

* typo

* Added comments

* Added complete example

* Minimized example

* typo

* Rephrased

* removed path as value

Co-authored-by: Jeremy Lundy <16428663+jlundy2@users.noreply.github.com>
Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
Co-authored-by: Luca Bonifacio <4151271+lucabonifacio@users.noreply.github.com>
Co-authored-by: Luis Martinez <lasote@gmail.com>
Co-authored-by: James <james@conan.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czoido czoido czoido left review comments

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.48
Development

Successfully merging this pull request may close these issues.

how to set and use the PYTHONPATH
3 participants
@franramirez688 @czoido @memsharded