Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Typo error in os_version for CMAKE_SYSTEM_VERSION? #2513

Closed
1 task done
lucabonifacio opened this issue Apr 28, 2022 · 1 comment · Fixed by #2515
Closed
1 task done

[question] Typo error in os_version for CMAKE_SYSTEM_VERSION? #2513

lucabonifacio opened this issue Apr 28, 2022 · 1 comment · Fixed by #2515
Milestone

Comments

@lucabonifacio
Copy link

The latest documentation states that CMAKE_SYSTEM_VERSION is set to the value of self.settings.os_version if cross-build is detected.

It there a typo in os_version? Shouldn't be os.version (dot instead of underscore)?

Here the link to the documentation:
https://docs.conan.io/en/latest/reference/build_helpers/cmake.html?highlight=cmake_system_version#definitions

@lucabonifacio lucabonifacio changed the title [question] Typo error in os_version for CMAKE_SYSTEM_VERSION [question] Typo error in os_version for CMAKE_SYSTEM_VERSION? Apr 28, 2022
@czoido czoido self-assigned this Apr 28, 2022
@czoido
Copy link
Contributor

czoido commented Apr 28, 2022

Hi @lucabonifacio,
Yes, that's in fact a typo, thanks a lot for reporting. I'm transferring this to the docs repo. Please feel free to contribute a PR to fix that.

@czoido czoido transferred this issue from conan-io/conan Apr 28, 2022
@czoido czoido added this to the master milestone Apr 28, 2022
@czoido czoido removed their assignment Apr 28, 2022
lucabonifacio added a commit to lucabonifacio/conan-docs that referenced this issue Apr 28, 2022
czoido added a commit that referenced this issue May 3, 2022
* Remove reference to master banch (#2497)

It no longer exists in conan-io/consan repository

* Added conf information about new apple flags (#2506)

* Fix typo error for os_version in cmake.rst (#2515)

Fix: #2513

* Renamed all the base_source_folder -> export_sources_folder (#2514)

* Renamed all the base_source_folder -> export_sources_folder

* Update package_layout.rst

* Docs for 11112 and 11117 and 11103 (#2512)

* Docs for 11112 and 11117

* Update reference/conanfile/tools/cmake/cmaketoolchain.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

* Simplified Build Preset name

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

* [CMakeDeps] Added cmake_set_interface_link_directories property info (#2510)

* Added cmake_set_interface_link_directories property info

* Update cmakedeps.rst

* Update reference/conanfile/tools/cmake/cmakedeps.rst

Co-authored-by: Luis Martinez <lasote@gmail.com>

* Update cmakedeps.rst

* Update cmakedeps.rst

Co-authored-by: Luis Martinez <lasote@gmail.com>

* Docs for new autotools templates (#2511)

* add templates

* change argument

* [MSBuildToolchain][conf] Adding extra flags configurations to `MSBuildToolchain` (#2507)

* Added conf information

* Update microsoft.rst

* Update reference/conanfile/tools/microsoft.rst

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* Added env info to self.run() command (#2516)

* powershell env docs (#2517)

* powershell env docs

* added warning about env and PATH limits

* fixed CI

* some notes about relocatable libs (#2518)

* Docs: Add PKG_CONFIG_PATH to AutotoolsToolchain (#2509)

* add docs for PKG_CONFIG_PATH in toolchain

* Update reference/conanfile/tools/gnu/autotoolstoolchain.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Co-authored-by: Luis Martinez <lasote@gmail.com>
Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

* conan 1.48.0

* Example for conanrun (#2519)

* Added example for conanrun launcher

* typo

* Added comments

* Added complete example

* Minimized example

* typo

* Rephrased

* removed path as value

Co-authored-by: Jeremy Lundy <16428663+jlundy2@users.noreply.github.com>
Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
Co-authored-by: Luca Bonifacio <4151271+lucabonifacio@users.noreply.github.com>
Co-authored-by: Luis Martinez <lasote@gmail.com>
Co-authored-by: James <james@conan.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants