Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docu for CONAN_DISABLE_STRICT_MODE env var (#13039) #2950

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Add docu for CONAN_DISABLE_STRICT_MODE env var (#13039) #2950

merged 1 commit into from
Feb 16, 2023

Conversation

stevn
Copy link
Contributor

@stevn stevn commented Feb 3, 2023 •
edited by czoido
Loading

@stevn stevn mentioned this pull request Feb 3, 2023
Merged
5 tasks
AbrilRBS
AbrilRBS approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure about the base branch for the PR (@czoido will know better), but the wording looks good. Thanks for taking the time to document the new envar

@czoido
Copy link
Contributor

czoido commented Feb 13, 2023

I'm not quite sure about the base branch for the PR (@czoido will know better), but the wording looks good. Thanks for taking the time to document the new envar

The destination branch is good (develop) as this is linked to the 1.59 release.
Please @stevn can you sign the CLA? The ci seems to be waiting for that

@czoido czoido added this to the 1.59 milestone Feb 13, 2023
@stevn
Copy link
Contributor Author

stevn commented Feb 13, 2023

I'm not quite sure about the base branch for the PR (@czoido will know better), but the wording looks good. Thanks for taking the time to document the new envar

The destination branch is good (develop) as this is linked to the 1.59 release. Please @stevn can you sign the CLA? The ci seems to be waiting for that

@czoido I'm slightly confused. I can't find the link to sign the CLA. I already signed it over here though: #2813

@czoido czoido closed this Feb 14, 2023
@czoido czoido reopened this Feb 14, 2023
@czoido
Copy link
Contributor

czoido commented Feb 14, 2023

I'm not quite sure about the base branch for the PR (@czoido will know better), but the wording looks good. Thanks for taking the time to document the new envar

The destination branch is good (develop) as this is linked to the 1.59 release. Please @stevn can you sign the CLA? The ci seems to be waiting for that

@czoido I'm slightly confused. I can't find the link to sign the CLA. I already signed it over here though: #2813

Sorry, looks like it got stuck, after closing and opening the PR now it's green

@czoido czoido merged commit b29a50c into conan-io:develop Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.59
Development

Successfully merging this pull request may close these issues.
3 participants
@stevn @czoido @AbrilRBS