Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds github settings file for portable labels #951

Merged
merged 2 commits into from
Nov 23, 2018

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Nov 23, 2018

Has to be merged to develop branch for changes to take effect

After merge we need to activate the app here: https://probot.github.io/apps/settings/

@ghost ghost assigned danimtb Nov 23, 2018
@ghost ghost added the stage: review label Nov 23, 2018
@danimtb danimtb removed their assignment Nov 23, 2018
@danimtb
Copy link
Member Author

danimtb commented Nov 23, 2018

CI was cancelled as it is not affected by this PR

@jgsogo
Copy link
Contributor

jgsogo commented Nov 23, 2018

Do you want to keep this file almost-equal for conan-io/conan and conan-community/community too, or it is just intended for this repo?

If the answer is the first one, then it is ok, otherwise I would add the has_projects=False too (I don't know if has_downloads=False is needed too).

@ghost ghost assigned danimtb Nov 23, 2018
@danimtb danimtb removed their assignment Nov 23, 2018
@jgsogo
Copy link
Contributor

jgsogo commented Nov 23, 2018

What about this (https://github.com/probot/probot-config) to share configuration between repos? Will it work? Having a conan-io/conan: .github/common-settings.yml and add a reference (and specialize) to it from the .github/settings.yml file of every repo

@danimtb
Copy link
Member Author

danimtb commented Nov 23, 2018

I think we could at this in the future if this kind of settings start to grow. I don't see this labels changing very much in a short term and configs are easy enough to be copy-pasted 😄

However, if you feel so we can start putting this common labels in conan-io/conan repo and the reuse them in here... I just wanted to start with a smaller repo like this one

Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Al toro! Let's go with it. Who will authorize the bot?

@jgsogo jgsogo merged commit 5d35656 into conan-io:develop Nov 23, 2018
@ghost ghost removed the stage: review label Nov 23, 2018
@danimtb
Copy link
Member Author

danimtb commented Nov 23, 2018

I am the one doing it! 🐮 🤠

@danimtb
Copy link
Member Author

danimtb commented Nov 23, 2018

Done! Bu labels were not updated 🤦‍♂️ Maybe we need to push a new change with the app now active... 🤔

@jgsogo
Copy link
Contributor

jgsogo commented Nov 23, 2018

Sure, an empty commit to develop should be enough

danimtb added a commit that referenced this pull request Dec 7, 2018
* Adds github settings file for portable labels (#951)

* Adds github settings file for portable labels

* make it generic

* improve seealso in android studio

* stettings

* #3883 Update inspect command (#940)

* #3883 Update inspect command

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #3883 Update Inspect command output

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #3883 Update default options for inspect

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Added entry in the MSBuild reference. (#854)

* Added entry in the MSBuild reference.

* Update output_binary_log and get_version()

* typo readme

* fix default

* clarification

* review

* undocumented parameter

* fix

* Make generator documentation (#955)

* Make generator documentation

* updated example

* Added toctrees

* review text

* review

* add missing variables for reference

* Updated with information of the test and with new table

* Get tool new parameters (#961)

* Add `include_prerelease` and `loose` option to version range expression (#938)

* Add `prerelease` and `strict` option to version range expression

* Update version_ranges.rst

* Change to `loose` and `include_prerelease` option

* Update version_ranges.rst

* Add example with both parameters

* Added CONAN_CMAKE_SILENT_OUTPUT description to the cmake generator (#962)

* Update attributes.rst (#966)

Fixing typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants