Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visjs local #972

Merged
merged 4 commits into from Dec 15, 2018

Conversation

Projects
None yet
2 participants
@memsharded
Copy link
Contributor

commented Dec 14, 2018

No description provided.

@ghost ghost assigned memsharded Dec 14, 2018

@ghost ghost added the stage: review label Dec 14, 2018

@memsharded memsharded assigned danimtb and unassigned memsharded Dec 14, 2018

@memsharded memsharded referenced this pull request Dec 14, 2018

Merged

Feature/visjs #4133

@danimtb
Copy link
Member

left a comment

It is not clear to me how you can use those .js files downloaded in your config folder. How is it done? Replacing the paths by hand on the html files?

IMO a suggestion about should be made at least

Show resolved Hide resolved reference/commands/consumer/info.rst Outdated
Show resolved Hide resolved reference/commands/consumer/info.rst Outdated
Update reference/commands/consumer/info.rst
Co-Authored-By: memsharded <james@conan.io>

@ghost ghost assigned memsharded Dec 14, 2018

Update reference/commands/consumer/info.rst
Co-Authored-By: memsharded <james@conan.io>
@memsharded

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2018

No, it is not necessary to change anything manually. Conan will do it automatically, using the path to the files in the cache.

@danimtb

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

perfect! Please include a brief explanation about this because I think it is not obvious in the text

@danimtb danimtb merged commit fcbee01 into conan-io:develop Dec 15, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Dec 15, 2018

@memsharded memsharded deleted the memsharded:feature/visjs_local branch Dec 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.