Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visjs local #972

Merged
merged 4 commits into from Dec 15, 2018
Merged

visjs local #972

merged 4 commits into from Dec 15, 2018

Conversation

memsharded
Copy link
Member

No description provided.

@ghost ghost assigned memsharded Dec 14, 2018
@ghost ghost added the stage: review label Dec 14, 2018
@memsharded memsharded assigned danimtb and unassigned memsharded Dec 14, 2018
@memsharded memsharded mentioned this pull request Dec 14, 2018
Merged
danimtb
danimtb requested changes Dec 14, 2018
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear to me how you can use those .js files downloaded in your config folder. How is it done? Replacing the paths by hand on the html files?

IMO a suggestion about should be made at least

reference/commands/consumer/info.rst Outdated Show resolved Hide resolved
reference/commands/consumer/info.rst Outdated Show resolved Hide resolved
@danimtb @memsharded
Update reference/commands/consumer/info.rst
9b2387b 
Co-Authored-By: memsharded <james@conan.io>
@ghost ghost assigned memsharded Dec 14, 2018
@danimtb @memsharded
Update reference/commands/consumer/info.rst
d3d5b90 
Co-Authored-By: memsharded <james@conan.io>
@memsharded
Copy link
Member Author

No, it is not necessary to change anything manually. Conan will do it automatically, using the path to the files in the cache.

@danimtb
Copy link
Member

danimtb commented Dec 14, 2018

perfect! Please include a brief explanation about this because I think it is not obvious in the text

@danimtb danimtb merged commit fcbee01 into conan-io:develop Dec 15, 2018
@ghost ghost removed the stage: review label Dec 15, 2018
@memsharded memsharded deleted the feature/visjs_local branch December 16, 2018 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@memsharded @danimtb