Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] CMake 3.15 required #4

Merged
merged 3 commits into from
Nov 20, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
38 changes: 38 additions & 0 deletions design/004-tools-cmake.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@

# Proposal: Tools - CMake 3.15

| **Status** | **Accepted** |
|:------------------|:--------------------------------------------------|
| **RFC #** | [004](https://github.com/conan-io/tribe/pull/4) |
| **Submitted** | 2020-11-12 |
| **Tribe votes** | 馃憤 (45) 馃憥 (7) 馃憖 (5) |

---

## Summary
Declare CMake 3.15 as the lowest supported CMake version.


## Motivation
CMake is one of the main external tool we call from Conan, transparent integration and
reliability should be a priority. It is important to declare a minimum supported
version so we can run all the tests and be confident that the user will get the
expected results and no regressions will be introduced.


## Proposal
CMake 3.15 was [released on July 2019](https://github.com/Kitware/CMake/releases/tag/v3.15.0). Significant additions are:

* (CMake 3.14) _Visual Studio 16 2019_ generator.
* Variable `CMAKE_PROJECT_INCLUDE` to add a file to be included after the `project()`
call. This is used by Conan toolchains.
* Variable `CMAKE_MSVC_RUNTIME_LIBRARY` to select the runtime library library used
when targeting MSVC ABI.

[Link to the full changelog](https://cmake.org/cmake/help/latest/release/3.15.html).


## Comments
This proposal is approved considering that the situation will change from the moment of approval to
when Conan 2.0 is released. At that moment, we will evaluate user's feedback to check if it's
necessary to add some workarounds or opt-out behavior for users chained to previous versions.