[ issue 9 ] Change font size in tooltips slightly. Fix check for badg…

…e color; now checks against old issue count.
conardcarroll · Jun 3, 2010 · 7169a6d · 7169a6d
1 parent a907e34
commit 7169a6d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/main/resources/css/popup.css b/src/main/resources/css/popup.css
@@ -32,7 +32,7 @@ td {
 	background-color:#ffa;
 	border:1px solid #cc9;
 	padding:3px;
-	font-size:13px;
+	font-size:12px;
 	-webkit-box-shadow: 2px 2px 11px #666;
 }
 

diff --git a/src/main/resources/js/background.js b/src/main/resources/js/background.js
@@ -109,13 +109,14 @@ function updateIssueCount_(count) {
 	}
 	if (isNotificationEnabled() && count > issueCount_) {
 		showNotification_(count - issueCount_);
-	}	
+	}
+	var oldCount = issueCount_;
 	issueCount_ = count;
 	chrome.browserAction.setIcon({path: 'img/icon-signed-in.png'});
 	chrome.browserAction.setTitle({title: getFilterName() + ' - ' + issueCount_ + " Issues"});
 	if (issueCount_ > 0) {
 		var issueText = (issueCount_ > 999 ? '999+' : issueCount_ + '');
-		var color = (count > issueCount_ ? COLOR_RED_ : COLOR_BLUE_);
+		var color = (issueCount_ > oldCount ? COLOR_RED_ : COLOR_BLUE_);
 		chrome.browserAction.setBadgeText({text: issueText});
 		chrome.browserAction.setBadgeBackgroundColor({color: color});
 		return;

diff --git a/src/main/resources/js/options.js b/src/main/resources/js/options.js
@@ -75,8 +75,8 @@ function updateFilters(url) {
 		cache: false,
 		async: false,
 		complete: function(xhr, status) {
-			var $h = $(xhr.responseText);
-			$h.find('a[id^=filterlink]').each(function(index, value) {
+			var h = xhr.responseText;
+			$(h).find('a[id^=filterlink]').each(function(index, value) {
 				var id = $(value).attr('id');
 				var pos = id.lastIndexOf('_');
 				if (pos > -1) {