This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
Moved EXTRACTED_IMAGE_DIR to prediction/config.py and updated the rel… #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evant files to reflect that change.
|
Regarding the tests, I have 4 failing tests that seem to be related either to missing files or wrong file permissions. Where should I ask questions about that if I get stuck on it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…evant files to reflect that change.
Description
EXTRACTED_IMAGE_DIR was manually being set in files where it was being used. This was moved to a config file (prediction/config.py)
Reference to official issue
Fixes issue 208
Motivation and Context
You only need to change the value of EXTRACTED_IMAGE_DIR in one place
How Has This Been Tested?
I ran the tests called by the pre-commit git hook.
CLA