This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading http://localhost:8080/ throws an
IsADirectoryError: [Errno 21] Is a directory: '/'
Description
The endpoint is called every time the front end loads. Since the
dicom.readfile()
method is an IO op, I do atry/except
to catch theIOError
21. As it is, this error is only anticipated on page load because there's no default path to a dicom file. I return an 'empty' response back so that the error is handled on the server-side and presents the client side an opportunity to handle it too.To handle the empty response from the server.
Cornerstone
throws errors if handed empty fields on the front end. Since the functions trigger calls to the server endpoint on load (I am assuming this is because of theasync/await
computed functions -- please correct my reasoning here if I'm wrong) and has nothing to display, catering for instances of empty values mitigates these unnecessary errors. Check the changes in OpenDICOM.vue file.Reference to official issue
Fixes issue #206
Motivation and Context
This change removes the error logs for
IsADirectoryError
and also handles instances where a dicom file is not found.How Has This Been Tested?
CLA