Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brown 1837 #1299

Merged
merged 6 commits into from
Mar 11, 2023
Merged

Brown 1837 #1299

merged 6 commits into from
Mar 11, 2023

Conversation

SimonGreenhill
Copy link
Contributor

Pull request checklist

  • add new concept list
  • add new metadata
  • add new Concepticon concept sets
    • checked whether the new concept(s) can be applied to existing lists with
      concepticon notlinked --gloss "NEW_GLOSS"
  • add new Concepticon concept relations
  • refine existing Concepticon concept set mappings
  • refine Concepticon glosses
  • refine Concepticon concept relations
  • refine Concepticon concept definitions
  • retire data

Additional information

An early comparative and lexicostatistic paper. How cool is this from 1837?

Screen Shot 2023-02-25 at 21 01 46

@SimonGreenhill
Copy link
Contributor Author

(Also, publishes all his data too. It's been downhill since then :)

Copy link
Contributor

@LinguList LinguList left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can moderate this PR, many thanks, @SimonGreenhill, I'd ask @MuffinLinwist and @mathildavz to have a first review here, and I'd later double-check.

Copy link
Contributor

@LinguList LinguList left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the PDF, @SimonGreenhill, it would be better if you send it directly to @chrzyki so he can upload it to cdstar and will later look into its integration. This needs to be done anyway.

@chrzyki
Copy link
Contributor

chrzyki commented Mar 2, 2023

Regarding the PDF, @SimonGreenhill, it would be better if you send it directly to @chrzyki so he can upload it to cdstar and will later look into its integration. This needs to be done anyway.

Thanks, I've received the PDF. Will upload as soon as this is merged.

Copy link
Collaborator

@MuffinLinwist MuffinLinwist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LinguList and @SimonGreenhill, my review is done. The list seemed to be already finished (according to what I could see from the PDF), so I checked minor details and left two comments.

concepticondata/references/references.bib Outdated Show resolved Hide resolved
concepticondata/conceptlists.tsv Outdated Show resolved Hide resolved
@MuffinLinwist
Copy link
Collaborator

Thanks, @SimonGreenhill! All of my requested changes are now fixed.

@chrzyki chrzyki mentioned this pull request Mar 8, 2023
4 tasks
Copy link
Collaborator

@mathildavz mathildavz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one small comment/question, but other than that this looks great!

concepticondata/references/references.bib Show resolved Hide resolved
@AnnikaTjuka AnnikaTjuka mentioned this pull request Mar 9, 2023
3 tasks
@SimonGreenhill SimonGreenhill merged commit 04ee292 into master Mar 11, 2023
@SimonGreenhill SimonGreenhill deleted the brown1837 branch March 11, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants