-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brown 1837 #1299
Brown 1837 #1299
Conversation
(Also, publishes all his data too. It's been downhill since then :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can moderate this PR, many thanks, @SimonGreenhill, I'd ask @MuffinLinwist and @mathildavz to have a first review here, and I'd later double-check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the PDF, @SimonGreenhill, it would be better if you send it directly to @chrzyki so he can upload it to cdstar and will later look into its integration. This needs to be done anyway.
Thanks, I've received the PDF. Will upload as soon as this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LinguList and @SimonGreenhill, my review is done. The list seemed to be already finished (according to what I could see from the PDF), so I checked minor details and left two comments.
Thanks, @SimonGreenhill! All of my requested changes are now fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one small comment/question, but other than that this looks great!
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"
Additional information
An early comparative and lexicostatistic paper. How cool is this from 1837?