Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailing zeroes to SRCIDs #805

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Add trailing zeroes to SRCIDs #805

merged 1 commit into from
Mar 30, 2020

Conversation

chrzyki
Copy link
Contributor

@chrzyki chrzyki commented Mar 30, 2020

Pull request checklist

  • add new concept list
  • add new metadata
  • add new Concepticon concept sets
  • add new Concepticon concept relations
  • refine existing Concepticon concept set mappings
  • refine Concepticon glosses
  • refine Concepticon concept relations
  • refine Concepticon concept definitions
  • retire data

Additional information

This adds back trailing zeroes which carry semantics for the STEDT lookup and made the Lexibank fail. See also this issue for the dataset: lexibank/halenepal#14.

@chrzyki chrzyki requested a review from LinguList March 30, 2020 06:55
@LinguList
Copy link
Contributor

LinguList commented Mar 30, 2020 via email

@AnnikaTjuka
Copy link
Collaborator

We were actually aware of the deleted zeros, see #749 . But we didn't discuss it further.

I have gotten into the habit of opening the concept lists only in Sublime, so that something like this doesn't happen again.

@LinguList
Copy link
Contributor

LinguList commented Mar 30, 2020 via email

@chrzyki
Copy link
Contributor Author

chrzyki commented Mar 30, 2020

I missed it as well and should have been more careful. However, it is a good lesson and it shows that everything is connected (which is a good thing I think!) and that our pipeline gets better at catching these things. Can I get an approval to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants