Set an instanced pipeline per PR #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoldershaw
commented
Jul 9, 2021
pipelines/pr.yml
Outdated
Comment on lines
160
to
151
| # TODO: now that this is per PR pipeline, caches might end up taking a | ||
| # ton of disk...figure out if this is a problem. | ||
| caches: [{path: cache}] |
There was a problem hiding this comment.
This is what I was talking about in retro. I think without some sort of GC mechanism for task caches we'll run into issues, since the size of the pr instance group never actually shrinks (old PR pipelines will get archived, but it seems as though task caches remain for archived pipelines)
There was a problem hiding this comment.
No longer blocked (see concourse/concourse#7272)
aoldershaw
force-pushed
the
prs-across
branch
2 times, most recently
from
208abcf
to
00d90e8
Compare
aoldershaw
force-pushed
the
prs-across
branch
5 times, most recently
from
513dab5
to
c62b612
Compare
since we no longer have to deal with version: every + passed constraints, we can now build the PR images once and fetch the result in each of the downstream jobs. this also makes it easier to test PRs, since you can just point to the image concourse/dev:pr-1234 Co-authored-by: Esteban Foronda <eforonda@vmware.com> Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the new dynamic
acrossbehaviour in concourse/concourse#7252 (so is therefore blocked on it). It makes the following changes:reconfigure-pipelinesis responsible for tracking changes to the list of PRs to the concourse repo (to themasterbranch only) and sets an instanced pipeline for each onereleasepipeline also tracks changes to the list of PRs to their correspondingrelease-M.m.xbranch, and does the sameversion: every+passedconstraints, we can have a proper "pipeline" that builds the image once and passes it along to downstream jobs:There were a few other changes related to the across step I added:
input_mapping- this means we no longer need to pass in bothpostgres-imageandpostgres-image-legacyto eachtestflightcontainer, and can just pass in the one we're actually using.