Skip to content

Commit

Permalink
atc: behaviour: update fly integration tests
Browse files Browse the repository at this point in the history
#5329

During the course of working on this issue, we tried to refactor the
existing API tests to be resilient to changes in the JSON structure. It
seems reasonable to have some assertions about the JSON structure of the
output of fly commands using the `--json` flag. Maybe these integration
tests could be similarly refactored to be a bit more robust (maybe
leaving only a single tests that is so obsessed with JSON), but we're
not going to tackle that now.

Signed-off-by: Bishoy Youssef <byoussef@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
  • Loading branch information
YoussB and Jamie Klassen committed Mar 19, 2020
1 parent 2271329 commit 9308f14
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions fly/integration/pipelines_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ var _ = Describe("Fly CLI", func() {
"name": "pipeline-1-longer",
"paused": false,
"public": false,
"archived": false,
"team_name": "",
"last_updated": 1
},
Expand All @@ -61,6 +62,7 @@ var _ = Describe("Fly CLI", func() {
"name": "pipeline-2",
"paused": true,
"public": false,
"archived": false,
"team_name": "",
"last_updated": 1
},
Expand All @@ -69,6 +71,7 @@ var _ = Describe("Fly CLI", func() {
"name": "pipeline-3",
"paused": false,
"public": true,
"archived": false,
"team_name": "",
"last_updated": 1
}
Expand Down Expand Up @@ -130,6 +133,7 @@ var _ = Describe("Fly CLI", func() {
"name": "pipeline-1-longer",
"paused": false,
"public": false,
"archived": false,
"team_name": "main",
"last_updated": 1
},
Expand All @@ -138,6 +142,7 @@ var _ = Describe("Fly CLI", func() {
"name": "pipeline-2",
"paused": true,
"public": false,
"archived": false,
"team_name": "main",
"last_updated": 1
},
Expand All @@ -146,6 +151,7 @@ var _ = Describe("Fly CLI", func() {
"name": "pipeline-3",
"paused": false,
"public": true,
"archived": false,
"team_name": "main",
"last_updated": 1
},
Expand All @@ -154,6 +160,7 @@ var _ = Describe("Fly CLI", func() {
"name": "foreign-pipeline-1",
"paused": false,
"public": true,
"archived": false,
"team_name": "other",
"last_updated": 1
},
Expand All @@ -162,6 +169,7 @@ var _ = Describe("Fly CLI", func() {
"name": "foreign-pipeline-2",
"paused": false,
"public": true,
"archived": false,
"team_name": "other",
"last_updated": 1
}
Expand Down

0 comments on commit 9308f14

Please sign in to comment.