behavior: runtime: fix fast print-then-exit

calling process.Delete cancels its IO, so wait on the IO to finish first

fixes #6775

Signed-off-by: Alex Suraci <suraci.alex@gmail.com>

worker/runtime/process.go

@@ -41,13 +41,13 @@ func (p *Process) Wait() (int, error) {
 		return 0, fmt.Errorf("waiting for exit status: %w", err)
 	}
 
+	p.process.IO().Wait()
+
 	_, err = p.process.Delete(context.Background())
 	if err != nil {
 		return 0, fmt.Errorf("delete process: %w", err)
 	}
 
-	p.process.IO().Wait()
-
 	return int(status.ExitCode()), nil
 }
 

worker/runtime/process_test.go

@@ -48,6 +48,7 @@ func (s *ProcessSuite) TestWaitStatusErr() {
 
 func (s *ProcessSuite) TestProcessWaitDeleteError() {
 	s.ch <- *containerd.NewExitStatus(0, time.Now(), nil)
+	s.containerdProcess.IOReturns(s.io)
 
 	expectedErr := errors.New("status-err")
 	s.containerdProcess.DeleteReturns(nil, expectedErr)
@@ -60,6 +61,11 @@ func (s *ProcessSuite) TestProcessWaitBlocksUntilIOFinishes() {
 	s.ch <- *containerd.NewExitStatus(0, time.Now(), nil)
 	s.containerdProcess.IOReturns(s.io)
 
+	s.io.WaitStub = func() {
+		// ensure Wait() is called before Delete() which cancels IO
+		s.Equal(0, s.containerdProcess.DeleteCallCount())
+	}
+
 	_, err := s.process.Wait()
 	s.NoError(err)