Skip to content

Commit

Permalink
Support a way to skip implied get after put.
Browse files Browse the repository at this point in the history
Signed-off-by: Evan <chaol@vmware.com>
  • Loading branch information
evanchaoli committed Sep 9, 2022
1 parent 9ef355d commit f08aa81
Show file tree
Hide file tree
Showing 3 changed files with 77 additions and 0 deletions.
5 changes: 5 additions & 0 deletions atc/builds/planner.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,11 @@ func (visitor *planVisitor) VisitPut(step *atc.PutStep) error {

plan.Put.TypeImage = visitor.resourceTypes.ImageForType(plan.ID, resource.Type, step.Tags, visitor.manuallyTriggered)

if step.NoGet {
visitor.plan = plan
return nil
}

dependentGetPlan := visitor.planFactory.NewPlan(atc.GetPlan{
Type: resource.Type,
Name: logicalName,
Expand Down
71 changes: 71 additions & 0 deletions atc/builds/planner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1168,6 +1168,77 @@ var factoryTests = []PlannerTest{
}
}`,
},
{
Title: "put step with no_get",
Config: &atc.PutStep{
Name: "some-name",
Resource: "some-resource",
Params: atc.Params{"some": "params"},
Tags: atc.Tags{"tag-1", "tag-2"},
Inputs: &atc.InputsConfig{All: true},
NoGet: true,
},
Inputs: []db.BuildInput{
{
Name: "some-name",
Version: atc.Version{"some": "version"},
},
},
ManuallyTriggered: true,
CompareIDs: true,
PlanJSON: `{
"id": "1",
"put": {
"name": "some-name",
"type": "some-resource-type",
"resource": "some-resource",
"source": {
"some": "source",
"default-key": "default-value"
},
"params": {"some":"params"},
"tags": ["tag-1", "tag-2"],
"inputs": "all",
"image": {
"base_type": "some-base-resource-type",
"check_plan": {
"id": "1/image-check",
"check": {
"name": "some-resource-type",
"type": "some-base-resource-type",
"resource_type": "some-resource-type",
"source": { "some": "type-source" },
"image": {
"base_type": "some-base-resource-type"
},
"interval": "1m0s",
"skip_interval": true,
"tags": [
"tag-1",
"tag-2"
]
}
},
"get_plan": {
"id": "1/image-get",
"get": {
"name": "some-resource-type",
"type": "some-base-resource-type",
"source": { "some": "type-source" },
"image": {
"base_type": "some-base-resource-type"
},
"version_from": "1/image-check",
"tags": [
"tag-1",
"tag-2"
]
}
}
}
}
}`,
},
{
Title: "task step",

Expand Down
1 change: 1 addition & 0 deletions atc/steps.go
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ type PutStep struct {
Tags Tags `json:"tags,omitempty"`
GetParams Params `json:"get_params,omitempty"`
Timeout string `json:"timeout,omitempty"`
NoGet bool `json:"no_get,omitempty"`
}

func (step *PutStep) ResourceName() string {
Expand Down

0 comments on commit f08aa81

Please sign in to comment.