Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi-Pipeline View] Thumbnail preview on red pipelines #1462

Closed
2 of 5 tasks
jama22 opened this issue Aug 10, 2017 · 6 comments
Closed
2 of 5 tasks

[Multi-Pipeline View] Thumbnail preview on red pipelines #1462

jama22 opened this issue Aug 10, 2017 · 6 comments

Comments

@jama22
Copy link
Member

jama22 commented Aug 10, 2017

Feature Request

What challenge are you facing?

Based on the research the Concourse team has done interviewing folks, and the huge list of issues everyone has reported; we're finally going to do a multi-pipeline view for Concourse users. A lot of the specific research and aggregation of tickets can be found in issue #1259 .

A Modest Proposal

dashboard_by_team_1462

@voelzmo
Copy link

voelzmo commented Aug 18, 2017

This might be a stupid question, but are you going to introduce now the concept of a "pipeline"? I know, that technically what you're building is a pipeline, but concourse doesn't actually know anything about that.

So, when you're trying to indicate "for how long a pipeline has been failing", what does that mean? That not all jobs in that pipeline have been green at the same time for an amount of time? Or is this really a concept of the same inputs flowing from "beginning to end"?

I'm asking this, because e.g. for github badges and similar purposes, up to now there was no notion of getting the state of an entire pipeline, and I'm wondering how this is calculated or introduced.

Thanks!

@jama22
Copy link
Member Author

jama22 commented Aug 23, 2017

Good question @voelzmo ! We're actually using this thumbnail view as a way to play around with new visualizations of the pipeline. To your point, Concourse itself, specifically the ATC, doesn't "know" about the shape of the pipeline. In this dashboard view, our first attempt to answer the question " how long a pipeline has been failing" was to simply record how long a job in the pipeline has been in the "red" state. This has some value to teams but most people will probably want to know more about (i.e. how long did something take to run, when was the last time it ran, etc.) These are valid questions that we're going to tackle specifically in our next set of issues: pipeline visualization. We're still trying to formalize our thinking on this, but I think some of the best ways to surface this information is going to be in how we present information in the resource itself (i.e. how long has a resource spent in a run state vs the "pipeline")

@vito
Copy link
Member

vito commented Sep 14, 2017

We noticed that a 5px margin looks pretty good for both small pipelines and "realistic" medium-sized pipelines (like ci.concourse.ci), however in some extreme examples the margin overwhelms the actual pipeline, which leaves jobs pixel then and can even leave the thumbnail blank.

screen shot 2017-09-14 at 11 04 03 am

I don't think we should optimize for this use case - it looks pretty good for..."normal" pipelines:

screen shot 2017-09-14 at 11 05 08 am

One idea: min-width on jobs, and marquee on overflow? 😛

@vito
Copy link
Member

vito commented Sep 14, 2017

We spiked for a bit on another idea, which is to have the box expand if the pipeline grid has a certain number of columns:

screen shot 2017-09-14 at 11 50 52 am

This is kinda similar to tiling approaches used by Windows 8+.

Downsides/gotchas:

  • May leave a blank space at the end and wrap if it's in the last column but requires 2 cells.
  • Leaves extra space at the end since there's no more justifying (it's just float: left).
  • Assumes we always display the thumbnail. We also removed the sorting so we could easily test positioning.
  • Duration interferes as it makes the box higher, disrupting the float: left.

@Lindsayauchin
Copy link
Contributor

Lindsayauchin commented Sep 14, 2017

Solution to the interference of the duration is aligning it with the icon and then the pipeline name below. Showing duration for all states in this example there would be a new icon of an infinity loop for a pipelines that is hanging forever.
dashboard_all_expanded

pivotal-gabriel-dumitrescu pushed a commit that referenced this issue Sep 14, 2017
Submodule src/github.com/concourse/atc 7ade9c3..c30aa33:
  > Dashboard: only compute graph once per pipeline
  > Dashboard: add tile layout

#1462

Signed-off-by: Gabriel Dumitrescu <gdumitrescu@pivotal.io>
mhuangpivotal pushed a commit to vmware-archive/atc that referenced this issue Sep 18, 2017
- Update pipeline duration text

concourse/concourse#1462

Signed-off-by: Gabriel Dumitrescu <gdumitrescu@pivotal.io>
mhuangpivotal added a commit that referenced this issue Sep 18, 2017
#1462

Submodule src/github.com/concourse/atc c30aa33..31727be:
  > Dashboard: rewrite dashboard preview logic
  > fix wats test now that we don't sort pipelines

Signed-off-by: Gabriel Dumitrescu <gdumitrescu@pivotal.io>
@jama22 jama22 removed this from the v3.5.0 milestone Sep 19, 2017
@jama22
Copy link
Member Author

jama22 commented Sep 26, 2017

such iteration, much wow

@jama22 jama22 closed this as completed Sep 26, 2017
@jama22 jama22 added this to the v3.6.0 milestone Oct 25, 2017
xtremerui pushed a commit to vmware-archive/web that referenced this issue Jan 11, 2018
- Update pipeline duration text

concourse/concourse#1462

Signed-off-by: Gabriel Dumitrescu <gdumitrescu@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants