add link to manually send login token to fly #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwhitby
force-pushed
the
fly-login-link
branch
from
cf016db
to
991ab11
Compare
…re requests Signed-off-by: Rob Whitby <rob.whitby@springer.com>
robwhitby
force-pushed
the
fly-login-link
branch
from
991ab11
to
c00ea55
Compare
jamieklassen
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
Looks like there's no other way to get Safari to cooperate, and I don't think it's worth making fly use HTTPS just to listen for tokens (and use a self-signed cert or similar trickery). So the page looks like
and when you click the 'send token to fly directly' link you go to a blank page (since fly's token listener doesn't send any HTML in the response). It's kinda ugly but only appears in such a narrow use case that I don't think it's super urgent to address.
This was referenced Sep 11, 2019
jomsie
added
the
release/documented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3747
adds a link to the local fly server for when the browser blocks the automated attempt, and pasting the token is not possible because fly only accepts it on stdin for
fly login.The UI/text probably needs some polish :)