web: behaviour: add loading view to dashboard #5458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Issue
Fixes #2935 (this time on 6.x).
Why do we need this PR?
As with #5427, add a spinner to the dashboard before
any API responses come back. Note that this isn't as useful for 6.x
since typically the user will have a cached API response, which is very
quick to load. However, it's easy to do, so might as well!
This commit uses a slightly different design than
#5427 - rather than having any text next to the
spinner, just display a spinner (in the center of the screen). I don't
have strong opinions either way, but the thinking was that we probably
don't need to tell the user what a spinner means! Happy to change it
to match the other design, though.
Changes proposed in this pull request
Contributor Checklist
Reviewer Checklist