Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config file for PullRequest bot automation #5564

Merged
merged 1 commit into from
May 11, 2020

Conversation

xtremerui
Copy link
Contributor

This just simply adding a configuration file for this (bot)[https://github.com/xtremerui/auto-pr-team/blob/master/index.js] so an owner of a pull-request against concourse/concourse could be added to concourse org contributor team.

jamieklassen
jamieklassen previously approved these changes May 11, 2020
Copy link
Member

@jamieklassen jamieklassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda want the team name to be 'Contributors' instead of 'Contributor' since other team names are plural (like Alumni & Developers), but it would take coordinating against concourse/hush-house#127, so I'm not fussed. Otherwise, based on:

https://github.com/xtremerui/auto-pr-team/blob/13315a8aa7833d03596f784c12e29502ce1c15bc/index.js#L23-L32

it seems like this will be a no-op until a 'contributor' team is created, right? Let's not forget to create it.

Signed-off-by: James Thomson <jthomson@pivotal.io>
@xtremerui
Copy link
Contributor Author

Good point lets go with contributors. Though I don't have the permission to create the team under concourse org. Neither can I accept the request of adding the auto_pr_team bot to concourse/concourse repo.

Copy link
Member

@jamieklassen jamieklassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the bot is already integrated:
Screen Shot 2020-05-11 at 5 35 15 PM

EDIT: I also created https://github.com/orgs/concourse/teams/contributors

@xtremerui xtremerui merged commit 3ac5db5 into master May 11, 2020
@xtremerui xtremerui deleted the contributor-automation branch May 11, 2020 21:53
@taylorsilva taylorsilva added the release/no-impact This is an issue that never affected released versions (i.e. a regression caught prior to shipping). label May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/no-impact This is an issue that never affected released versions (i.e. a regression caught prior to shipping).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants