containerd: properly populate /etc/hosts and /etc/hostname #7041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hostname is the container's handle. This is now added to /etc/hostname. Both the hostname and the container's IP is appended to /etc/hosts. The container's IP is only available once the network has been initialized. Therefore, the original /etc/hosts has to be updated after. The /etc/hosts on the container is bindmounted to a file on the worker. We simply update this file directly. issue#6811 Co-authored-by: Muntasir Chowdhury <mchowdhury@pivotal.io> Signed-off-by: Bohan Chen <bochen@pivotal.io>
taylorsilva
requested changes
May 21, 2021
Use already provided s.GardenBackend instead of creating custom backend. Remove println used for debugging. Signed-off-by: Muntasir Chowdhury <mchowdhury@pivotal.io> Signed-off-by: Muntasir Chowdhury <muntasir.mzc@gmail.com>
|
Thanks! Good eye with the test cleanup suggestions. |
|
would it be possible to get this included in the next point release? |
|
@taylorsilva Do you know when this is planned to be released? |
|
Soon maybe? Looking at our milestone: https://github.com/concourse/concourse/milestone/75 |
|
@jaredstehler , |
It did. We have installed it already and tested it fixes the issue we were having 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
cc: @chenbh
closes #6811
/etc/hostname/etc/hostsNotes to reviewer
The container's IP is only available once the network has been initialized. Therefore, the original /etc/hosts has to be updated after. The /etc/hosts on the container is bindmounted to a file on the worker. We simply update this
file directly.
To test simply jump on to a running container and open the
/etc/hostsand/etc/hostnamefile. You can also runhostname -fandhostname -ito validate.Release Note
/etc/hostsand/etc/hostnameare correctly populated