Delete btrfs volume if it exists when using the overlay driver #7461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoldershaw
reviewed
Aug 26, 2021
but only when using the overlay driver. We found that if you ended up in a state where you were trying to run a worker with overlay and created the overlay mounts intside a btrfs mount, lots of weird stuff would happen with volume creation and COW volumes specifically. This commit ensures that if you're using overlay and the volume path is a btrfs mount, then btrfs mount is cleaned up. Signed-off-by: Taylor Silva <tsilva@pivotal.io> Co-authored-by: Esteban Foronda <eforonda@vmware.com>
taylorsilva
force-pushed
the
issue/7430
branch
from
aa4c58c
to
762e42b
Compare
|
I don't think we need to delete each sub-volume. The sub-volumes exist in the The issue we ran into during our testing was when there were overlay mounts inside the btrfs mount. Then the top-level btrfs volume could not be unmounted. The same does not happen when there are btrfs subvolumes. |
aoldershaw
approved these changes
Aug 27, 2021
clarafu
changed the title
clarafu
added
the
release/undocumented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
closes #7430
We found that if you ended up in a state where you were trying to run a
worker with overlay and created the overlay mounts intside a btrfs
mount, lots of weird stuff would happen with volume creation and COW
volumes specifically.
This commit ensures that if you're using overlay and the volume path is
a btrfs mount, then the btrfs mount is cleaned up.
Release Note