Allow to specify port fly login will listen for the callback #8111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Ruff <fabian.ruff@sap.com>
databus23
force-pushed
the
fly-local-port
branch
from
df7b8af
to
13fb1e9
Compare
xtremerui
added
enhancement
release/documented
|
Hi, thx for the PR. Is it possible to add a test udner concourse/fly/integration/login_test.go Line 415 in 13fb1e9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
This PR adds a flag
token-listenerflag tofly loginto specify the local listen address explicitly.This enables workflows where fly is running remotely (e.g. via ssh or docker) and the port needs
to be known a priori to configure a static port forward.
closes #4837
Notes to reviewer
I didn't bother to support this new flag in the legacy auth code path as it seems this is only for really old concourse versions and seems unused at this point.
Release Note
fly: Add optional --token-listener flag to login command